Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update semantic conventions to 1.19.0 #3233

Closed
wants to merge 5 commits into from
Closed

update semantic conventions to 1.19.0 #3233

wants to merge 5 commits into from

Conversation

tsloughter
Copy link
Member

Description

This updates the semantic conventions library to version 1.19.0 and the generator to 0.18.0.

See open-telemetry/build-tools#157 for context on the change to the generate script.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tsloughter tsloughter requested a review from a team March 22, 2023 18:20
@tsloughter tsloughter mentioned this pull request Mar 22, 2023
Closed
@srikanthccv
Copy link
Member

@tsloughter, we have some resource semantic convention attributes as top-level constants in the SDK. We couldn't remove them because removing public symbols would be a breaking change. We have deprecated them but must continue to maintain them until the 2.0 release to remove them. Since we can't use ResourceAttriubtes from this package, can you keep the string equivalent for those constants here https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py#L92

@tsloughter
Copy link
Member Author

@srikanthccv sorry I forgot about this comment!

Do you just mean the old FAAS attributes?

@srikanthccv
Copy link
Member

Yes. It seems like there is another PR here that does the same #3251.

@tsloughter
Copy link
Member Author

Ah, should I close this since there is the one to upgrade to 1.20? Or are both needed in order to publish a version of semconv at 1.19?

@srikanthccv
Copy link
Member

I think you can close this. We haven't published the semantic conventions for each release.

@tsloughter tsloughter closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsloughter @srikanthccv @lzchen